-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make cluster
command
#705
base: main
Are you sure you want to change the base?
Conversation
Add the ability to create a cluster for testing by using `make cluster`. Multiple clusters can be created by utilizing the `MULTICLUSTER=true` option. This allows developers to easily create a cluster to run manual testing on. Most of the code has been carved out of `tests/e2e/integ-suite-kind.sh` which now relies on the cluster existing (the Makefile has been updated to create it when running the tests). Signed-off-by: Mike Kolesnik <[email protected]>
|
Hi @mkolesnik. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's not create yet another hack
/tools
directory :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, where do you propose we put this?
I looked at common/scripts
but it seems it's all auto updated from istion/common-files.
Perhaps in tools
then?
/ok-to-test |
@mkolesnik: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / why we need it:
Add the ability to create a cluster for testing by using
make cluster
. Multiple clusters can be created by utilizing theMULTICLUSTER=true
option.This allows developers to easily create a cluster to run manual testing on.
Most of the code has been carved out of
tests/e2e/integ-suite-kind.sh
which now relies on the cluster existing (the Makefile has been updated to create it when running the tests).Which issue(s) this PR fixes:
Fixes #554
Related Issue/PR #
Additional information: