Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make cluster command #705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkolesnik
Copy link

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Add the ability to create a cluster for testing by using make cluster. Multiple clusters can be created by utilizing the MULTICLUSTER=true option.
This allows developers to easily create a cluster to run manual testing on.

Most of the code has been carved out of tests/e2e/integ-suite-kind.sh which now relies on the cluster existing (the Makefile has been updated to create it when running the tests).

Which issue(s) this PR fixes:

Fixes #554

Related Issue/PR #

Additional information:

Add the ability to create a cluster for testing by using `make cluster`.
Multiple clusters can be created by utilizing the `MULTICLUSTER=true`
option.
This allows developers to easily create a cluster to run manual testing
on.

Most of the code has been carved out of `tests/e2e/integ-suite-kind.sh`
which now relies on the cluster existing (the Makefile has been updated
to create it when running the tests).

Signed-off-by: Mike Kolesnik <[email protected]>
@mkolesnik mkolesnik requested a review from a team as a code owner March 10, 2025 14:17
Copy link

linux-foundation-easycla bot commented Mar 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mkolesnik / name: Mike Kolesnik (17240c0)

@istio-testing
Copy link
Collaborator

Hi @mkolesnik. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's not create yet another hack/tools directory :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, where do you propose we put this?

I looked at common/scripts but it seems it's all auto updated from istion/common-files.
Perhaps in tools then?

@dgn
Copy link
Collaborator

dgn commented Mar 10, 2025

/ok-to-test

@istio-testing
Copy link
Collaborator

@mkolesnik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_sail-operator_main 17240c0 link true /test lint
scorecard_sail-operator_main 17240c0 link true /test scorecard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add make clusters to allow creating KinD clusters for local development
3 participants