Check IstioCNI status for IstioRevisions that depend on IstioCNI #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 74.29% 74.34% +0.05%
==========================================
Files 43 44 +1
Lines 2575 2631 +56
==========================================
+ Hits 1913 1956 +43
- Misses 569 580 +11
- Partials 93 95 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luksa
force-pushed
the
istio-cni-status
branch
13 times, most recently
from
5caeea7 to
22d710f
Compare
Previously, when an IstioRevision depended on IstioCNI, either because the user enabled the use of IstioCNI through values.pilot.cni.enabled or because the platform profile enables it, the IstioRevision resource would show as healthy even though workloads would fail because IstioCNI hasn't been deployed. This commit adds a new `DependenciesHealthy` condition to `IstioRevision` and makes `IstioRevision.status.state` and the `STATUS` column report the fact that IstioCNI is missing or unhealthy. This makes it easier for users to see that their setup is misconfigured. Signed-off-by: Marko Lukša <[email protected]>
|
should we cover this in the IstioCNI integration test? Just a quick check of the happy/sad paths maybe - we could easily simulate an unhealthy IstioCNI there by manipulating status |
Signed-off-by: Marko Lukša <[email protected]>
|
@dgn integration test added. |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 27, 2025
* upstream/main: Check IstioCNI status for IstioRevisions that depend on IstioCNI (istio-ecosystem#711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an IstioRevision depended on IstioCNI, either because the user enabled the use of IstioCNI through
values.pilot.cni.enabledor because the platform profile enables it, the IstioRevision resource would show as healthy even though workloads would fail because IstioCNI hasn't been deployed. This commit adds a newDependenciesHealthycondition to IstioRevision and makesIstioRevision.status.stateand theSTATUScolumn report the fact that IstioCNI is missing or unhealthy. This makes it easier for users to see that their setup is misconfigured.