-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize 'HTTP/2' usage and replace URLs with Markdown links #16189
base: master
Are you sure you want to change the base?
Conversation
Hi @AdeshGhadage. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the request is to convert this entire file from .html
to .md
.
So you will need to rename the file extension and rewrite the contents to use markdown syntax, and not HTML syntax.
See https://github.com/istio/istio.io/tree/a0481a9889636202dbde5b511c0e9ff3a59f3520/content/en/docs/ambient/getting-started/deploy-sample-app for an example index.md
The latter is what our newer docs use, and HTML is later generated from them in an automated step by Hugo.
@bleggett I will look for any automation or helper I can find. If you know something to help me with, please let me know. |
Sorry for not being more clear.
URLs can't be broken and cause tables to overflow. They should be changed to a Markdown link with an appropriate anchor:
(Check Markdown source of this comment if you need) Do note that these changes need to be made in the |
Description
This is a PR for #16102 . I don't understand what you mean by "URLs to markdown" throughout the reference docs. I have checked the Hugo documentation and found the markdownify function, but when I used it here in HTML, it was not working.
Reviewers