Skip to content

Conversation

sridhargaddam
Copy link
Contributor

Related to: istio/istio#56484

@sridhargaddam sridhargaddam requested a review from a team as a code owner September 1, 2025 08:00
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2025
@sridhargaddam
Copy link
Contributor Author

The lint failures do not seem to be releated to this PR.

In ./public/docs/ambient/install/multicluster/multi-primary_multi-network/helm_test.sh line 27:
set_multi_network_vars
^--------------------^ SC2218 (error): This function is only defined later. Move the definition up.


In ./public/docs/ambient/install/multicluster/multi-primary_multi-network/helm_test.sh line 28:
setup_helm_repo
^-------------^ SC2218 (error): This function is only defined later. Move the definition up.


In ./public/docs/ambient/install/multicluster/multi-primary_multi-network/helm_test.sh line 86:
time configure_trust
     ^-------------^ SC2218 (error): This function is only defined later. Move the definition up.


In ./public/docs/ambient/install/multicluster/multi-primary_multi-network/helm_test.sh line 89:
time verify_load_balancing
     ^-------------------^ SC2218 (error): This function is only defined later. Move the definition up.

For more information:
  https://www.shellcheck.net/wiki/SC2218 -- This function is only defined lat...
make: *** [common/Makefile.common.mk:30: lint-scripts] Error 123

@sridhargaddam
Copy link
Contributor Author

/test lint

@sridhargaddam
Copy link
Contributor Author

@istio/wg-docs-maintainers-english PTAL, thanks.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2025
@sridhargaddam
Copy link
Contributor Author

/test lint

@dhawton
Copy link
Member

dhawton commented Sep 3, 2025

@istio/wg-docs-maintainers-english PTAL, thanks.

unfortunately, there's only 2 of us.. I've been extremely busy today and don't have the cycles. I will when I can.

@sridhargaddam
Copy link
Contributor Author

@kfaseela @howardjohn PTAL, thanks.

@dhawton
Copy link
Member

dhawton commented Sep 10, 2025

/retest

@Ajay-singh1
Copy link
Member

/test lint

@sridhargaddam
Copy link
Contributor Author

I updated the .spelling file as well, but still seeing linter errors. Any idea how to fix these errors?

Screenshot From 2025-09-10 18-58-45

@Ajay-singh1
Copy link
Member

@sridhargaddam Whatever you are seeing in red you have to add it in .spelling file and then sort the .spelling file using make format-spelling I guess.

@sridhargaddam
Copy link
Contributor Author

@sridhargaddam Whatever you are seeing in red you have to add it in .spelling file and then sort the .spelling file using make format-spelling I guess.

Hey @Ajay-singh1 thanks for chiming in. Using quotes around the IPv6 address is resolving the linter error as @kfaseela pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants