fix: Virtual Machine Installation WorkloadGroup yaml sample typo

[chinaran]

Reviewers

• Ambient
• Docs
• Installation
• Networking
• Performance and Scalability
• Extensions and Telemetry
• Security
• Test and Release
• User Experience
• Developer Infrastructure
• Localization/Translation

[istio-policy-bot]

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

• You can learn about how we write and maintain documentation, our style guidelines,
  and the available web site features by visiting Contributing to the Docs.

• In the next few minutes, an automatic preview of your change will be built with
  a full copy of the istio.io website. You can find this preview by clicking on
  the Details link next to the deploy/netlify entry in the status section of this
  page.

• We care about quality, so we've put in place a number of checks to ensure our documentation
  is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
  valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
  lint_istio.io entry in the status section. Click on the Details link to get a list of the
  problems with your PR. Fix those problems and push an update; this will automatically re-run the
  tests. Hopefully this time everything will be perfect!

• Once your changes are accepted and merged into the repository, they will initially show up
  on https://preliminary.istio.io. The changes will be published to https://istio.io
  the next time we do a major release (which typically happens every 3 months or so).
  To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
  release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[istio-testing]

Hi @chinaran. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zirain]

/ok-to-test

[sridhargaddam]

@chinaran, you will have to run make gen, update necessary files to fix the gencheck failure.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   content/en/docs/setup/install/virtual-machine/snips.sh

no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/content/en/docs/setup/install/virtual-machine/snips.sh b/content/en/docs/setup/install/virtual-machine/snips.sh
index f5eb7d3dd..a5b5eca00 100644
--- a/content/en/docs/setup/install/virtual-machine/snips.sh
+++ b/content/en/docs/setup/install/virtual-machine/snips.sh
@@ -154,7 +154,7 @@ spec:
       app: "${VM_APP}"
   template:
     serviceAccount: "${SERVICE_ACCOUNT}"
-    network: "${NETWORK}"
+    network: "${VM_NETWORK}"
   probe:
     periodSeconds: 5
     initialDelaySeconds: 1
ERROR: Some files need to be updated, please run 'make gen' and include any changed files in your PR

[chinaran]

@sridhargaddam Thanks for your reminder, it has been updated.

[sridhargaddam]

LGTM, thanks.

[chinaran]

@sridhargaddam Is this PR ready to be merged, please?

[sridhargaddam]

@sridhargaddam Is this PR ready to be merged, please?

I do not have merge permissions. @istio/wg-docs-maintainers-english can you PTAL?

[kfaseela]

I am wondering how the docs test was passing before, without this change. Can you make sure to update the test to cover this?

[chinaran]

I am wondering how the docs test was passing before, without this change. Can you make sure to update the test to cover this?

@kfaseela I'm not familiar with document testing. Which test are you referring to?

[kfaseela]

I am wondering how the docs test was passing before, without this change. Can you make sure to update the test to cover this?

@kfaseela I'm not familiar with document testing. Which test are you referring to?

@sridhargaddam could you please help point to the respective test files? I am a bit busy for the next two weeks.

[dhawton]

I am wondering how the docs test was passing before, without this change. Can you make sure to update the test to cover this?

The VM tests actually largely do not test the installation as it is slightly different due to the "virtual machines" actually being nothing more than a docker container running inside of a VM, and the cluster being kind as docker containers next to it. The changed code is actually not tested.