-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.14.0 #1039
base: dev
Are you sure you want to change the base?
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request updates the Maven Compiler Plugin version across multiple Maven project modules. In each module’s 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
wls-wahlvorstand-service/pom.xml (1)
32-32
: Maven Compiler Plugin Version UpdateThe version in the property
<maven.compiler.plugin.version>
has been updated from 3.13.0 to 3.14.0 as intended. This change is straightforward and is consistent with the PR objectives. Please verify that the new plugin version is fully compatible with Java 17 and the current project settings.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
wls-admin-service/pom.xml
(1 hunks)wls-auth-service/pom.xml
(1 hunks)wls-basisdaten-service/pom.xml
(1 hunks)wls-briefwahl-service/pom.xml
(1 hunks)wls-broadcast-service/pom.xml
(1 hunks)wls-common/pom.xml
(1 hunks)wls-eai-service/pom.xml
(1 hunks)wls-ergebnismeldung-service/pom.xml
(1 hunks)wls-infomanagement-service/pom.xml
(1 hunks)wls-monitoring-service/pom.xml
(1 hunks)wls-vorfaelleundvorkommnisse-service/pom.xml
(1 hunks)wls-wahlvorbereitung-service/pom.xml
(1 hunks)wls-wahlvorstand-service/pom.xml
(1 hunks)
🔇 Additional comments (12)
wls-broadcast-service/pom.xml (1)
32-32
: Consistent Update of Maven Compiler Plugin VersionThe property
<maven.compiler.plugin.version>
has been correctly updated to 3.14.0. This update is applied in a similar manner as in other projects. Ensure that any compiler-specific flags or configuration (if any) are still valid with the new version.wls-admin-service/pom.xml (1)
32-32
: Maven Compiler Plugin Version ChangeThe update to
<maven.compiler.plugin.version>3.14.0</maven.compiler.plugin.version>
is correctly applied. This aligns the admin service module with the overall update across projects. It is advisable to run a complete build to ensure no unforeseen issues arise from the upgraded plugin.wls-auth-service/pom.xml (1)
32-32
: Upgrade of Maven Compiler Plugin VersionThe Maven Compiler Plugin version has been updated from 3.13.0 to 3.14.0. This change appears to be uniform with the other modules. Please check that the new version’s behavior (especially regarding annotation processing and any custom compiler arguments) remains compatible with the service’s code base.
wls-monitoring-service/pom.xml (1)
32-32
: Updated Maven Compiler Plugin VersionThe monitoring service’s build configuration now specifies
<maven.compiler.plugin.version>3.14.0</maven.compiler.plugin.version>
, which is consistent with the PR objectives. This change should benefit from the enhancements of the newer compiler plugin version. A full regression build is recommended to ensure that there are no unexpected side effects when switching from 3.13.0.wls-eai-service/pom.xml (1)
32-32
: Maven Compiler Plugin Version Updated to 3.14.0
The version property has been correctly updated from 3.13.0 to 3.14.0. Please verify that the downstream build behavior remains unchanged with the new version.wls-wahlvorbereitung-service/pom.xml (1)
33-33
: Maven Compiler Plugin Version Bump Confirmed
The update to 3.14.0 in the properties section is consistent with the overall PR objective. It is recommended to run a full build to confirm there are no compatibility issues.wls-vorfaelleundvorkommnisse-service/pom.xml (1)
32-32
: Consistent Update of Maven Compiler Plugin Version
The property has been updated to 3.14.0 here as well. This consistent change across modules is good; please ensure integration tests are run after this update.wls-common/pom.xml (1)
28-28
: Updated Maven Compiler Plugin Version in Parent POM
The compiler plugin version has been updated to 3.14.0 in the common parent configuration. This change appears correct and is consistent with similar module updates.wls-infomanagement-service/pom.xml (1)
33-33
: Maven Compiler Plugin Version Change Confirmed
The plugin version is now set to 3.14.0. It would be beneficial to run a local build and regression tests in the infomanagement module to ensure the update does not introduce unexpected issues.wls-basisdaten-service/pom.xml (1)
33-33
: Updated Maven Compiler Plugin Version.
The property<maven.compiler.plugin.version>
has been updated from3.13.0
to3.14.0
. This update is in line with the PR objectives and appears to be correctly applied. Please be sure that the new version is fully compatible with the project’s compiler configuration and that no additional modifications are needed.wls-briefwahl-service/pom.xml (1)
33-33
: Maven Compiler Plugin Version Updated.
The version in the<properties>
section is now set to3.14.0
, which is consistent with the planned update. It would be a good idea to verify that the build and tests run successfully with this new compiler plugin version.wls-ergebnismeldung-service/pom.xml (1)
32-32
: Verified Plugin Version Update.
The<maven.compiler.plugin.version>
property has been successfully updated to3.14.0
. This change aligns with the broader update across projects. As a follow-up, please ensure that this update does not introduce any compatibility issues with the current Maven configuration and the related plugins.
c3d1afe
to
ce1d987
Compare
ce1d987
to
d4f1dad
Compare
This PR contains the following updates:
3.13.0
->3.14.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.