Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huge cleanups and optimizations #352

Open
wants to merge 60 commits into
base: dev
Choose a base branch
from
Open

Huge cleanups and optimizations #352

wants to merge 60 commits into from
+5,219 −4,872

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Jan 31, 2025 •
edited by PascalDR
Loading

This PR must be used with iam-proxy-italia branch italia/iam-proxy-italia#185:

  • adds a default_client_id and the possibility for each trust evaluation handler to use different client ids (experimental due to the LSP Potential requirements)
  • aims to remove all the duplicated code and overlapping classes born during the refactoring from 0.7 to 0.9, with the scope to simplify the implementations
  • extends the configurations and consolidates the example configuration to provide a more appropriate guidance to the implementers
  • removes the deprecation warning about pyhdantinc FieldValidationInfo
  • resolves Migrate federation published endpoint to new approach #334
  • Resolves Scout and remove dead code #342
  • ...

@peppelinux peppelinux marked this pull request as draft January 31, 2025 21:01
@peppelinux
Copy link
Member Author

these three should be cleaned up too

image

@peppelinux peppelinux mentioned this pull request Feb 10, 2025
Open
@PascalDR
fix: unused import and functions
d92fca7
@PascalDR
fix: removed unused class
74ff8c7
@PascalDR
fix: removed unused classes
15f5b47
@PascalDR
fix: removed unused functions
fc685b0
@PascalDR
fix: removed unused functions
10f77ee
@PascalDR
fix: moved unused file
9b04ebf
@PascalDR
fix: removed exceptions
6d9fc5a
@PascalDR
fix: removed unused code
09e1078
@PascalDR
fix: unused code
7368a66
@PascalDR
fix: unused import
99f9b93
@PascalDR
fix: removed unused function
f1d06ec
@PascalDR
fix: removed unused class
675ca6e
@PascalDR
fix: removed unused exception
80746c9
@PascalDR
fix: removed unused class and refactoring
f4393d3
@PascalDR
fix: moved class
1c068b6
@PascalDR
fix: removed unused functions
82e3205
@PascalDR
fix: refactoring
e5cdf02
@PascalDR
fix: typing and docs
753a0eb
@PascalDR
fix: cleaning, typing and docs
bd8d905
@PascalDR
fix: removed exception
145d0d9
@PascalDR
fix: import
ae0ed88
@PascalDR
fix: removed unused class
001a5f3
@PascalDR
fix: moved unused file
57c52c4
@PascalDR
fix: moved unused functions
4920326
@PascalDR
fix: type
9922865
@PascalDR
fix: removed unused file
688557f
@peppelinux peppelinux changed the title Federation and handler refacoring with huge cleanups and optimizations Huge cleanups and optimizations Feb 19, 2025
@peppelinux peppelinux marked this pull request as ready for review February 19, 2025 13:59
@peppelinux peppelinux requested a review from Zicchio February 19, 2025 13:59
peppelinux
peppelinux commented Feb 19, 2025
View reviewed changes
pyeudiw/federation/http_client.py
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PascalDR please move this http_client in general tools/utils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zicchio Zicchio Awaiting requested review from Zicchio

Assignees

@PascalDR PascalDR

Labels
None yet
Projects
EUDI WALLET IT Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scout and remove dead code Migrate federation published endpoint to new approach
2 participants
@peppelinux @PascalDR