Skip to content

Fix bash quoting, add type hints, code cleanup #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Fix bash quoting, add type hints, code cleanup #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b28260a
test: Compare exc.type with `is`
Oct 10, 2025
7502cd2
main() does not return a value
Oct 10, 2025
cacb772
Fix Action == SUPPRESS
Oct 10, 2025
5594fde
bash: Fix detection of redirection
Oct 10, 2025
d13f0ec
shellcheck: Remove backslash at end of line
Oct 9, 2025
9c05d1d
shellcheck: No $ needed in arithmetic context
Oct 9, 2025
36033a3
shellcheck: Declare variables as integers
Oct 9, 2025
310d664
shellcheck: Quote arguments
Oct 9, 2025
d8590c0
shellcheck: Use mapfile to preserve blanks
Oct 10, 2025
86f171a
shellcheck: Use for-loop to walk words
Oct 10, 2025
fd86678
shellcheck: Use ARRAY[*] instead of ARRAY[@]
Oct 10, 2025
cd4fe8a
Raise minimum supported Python version to 3.8
Oct 13, 2025
4f04000
style: Convert from old typing to native types
Oct 9, 2025
821f152
Add more type annotations
Oct 9, 2025
4e96f86
More manual typing code changes
Oct 10, 2025
aa7e0f6
Convert to list-comprehension
Oct 10, 2025
60bf105
Re-implement get_option_strings
Oct 10, 2025
1fb8052
Use shlex.quot() to do escaping
Oct 10, 2025
a9f230e
Fix accessing attribute .complete
Oct 10, 2025
0abe1be
Move shell fragments to separate files
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
test:
if: github.event_name != 'pull_request' || !contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)
name: Test py${{ matrix.python }}
runs-on: ubuntu-${{ matrix.python == 3.7 && '22.04' || 'latest' }}
runs-on: ubuntu-${{ 'latest' }}
strategy:
matrix:
python: [3.7, 3.12]
python: [3.8, 3.12]
steps:
- uses: actions/checkout@v4
with: {fetch-depth: 0}
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ authors = [{name = "Casper da Costa-Luis", email = "[email protected]"}]
maintainers = [{name = "Iterative", email = "[email protected]"}]
description = "Automagic shell tab completion for Python CLI applications"
readme = "README.rst"
requires-python = ">=3.7"
requires-python = ">=3.8"
keywords = ["tab", "complete", "completion", "shell", "bash", "zsh", "argparse"]
license = {text = "Apache-2.0"}
classifiers = [
Expand All @@ -49,7 +49,6 @@ classifiers = [
"Programming Language :: Other Scripting Engines",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down
Loading