Alternative to #434: download via .download temp file then rename #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py, to avoid partial jar if interrupted
… and comprehensive tests
|
Well done @pgcudahy. I'm no java dev and ran out of time and skills! Your solution is simpler though which is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a very slow internet connection, so interrupted downloads have often caused me problems. I saw that #434 from @potomato addressed this but seems to have stalled out. I'm a decent programmer but have no experience with java, so full disclosure that I used claude code to help me with this. I'm confident in the logic in GetCommand.java, but I'm not familiar with the testing framework. The tests look sensible to me and pass.