[bug fix] PHP Warning: Cannot assign an empty string to a string offset and different result of comparation of two string#2
Open
trioputrap wants to merge 1 commit intoiugrina:masterfrom
trioputrap:master
Open
[bug fix] PHP Warning: Cannot assign an empty string to a string offset and different result of comparation of two string#2trioputrap wants to merge 1 commit intoiugrina:masterfrom trioputrap:master
trioputrap wants to merge 1 commit intoiugrina:masterfrom
trioputrap:master
Conversation
se8820726
suggested changes
Mar 14, 2021
se8820726
left a comment
se8820726
left a comment
There was a problem hiding this comment.
str_plit is incorrect
str_split is true
$temp_string2 = str_plit($string2); => $temp_string2 = str_split($string2);
Author
|
Thank you! I mistyped the str_split |
| $str1_len = strlen($string1); | ||
| $str2_len = strlen($string2); | ||
| $temp_string2 = $string2; | ||
| $temp_string2 = str_plit($string2); |
There was a problem hiding this comment.
typo function name here
$temp_string2 = str_split($string2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple update to fix the issue about compare A to B doesn't equal B to A. This update also fix the "PHP Warning: Cannot assign an empty string to a string offset" on line 60 => $temp_string2[$j] = ''; because can not insert empty character ('') to a string.