Skip to content

Don't use embed video on community page #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChunkyProgrammer wants to merge 2 commits into
base: master
Choose a base branch
from
+47 −3
Open

Don't use embed video on community page #5159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5112f
don't use embed video on community page
ChunkyProgrammer Jan 27, 2025
d5dfceb
Remove some code duplication
ChunkyProgrammer Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 47 additions & 3 deletions src/invidious/frontend/comments_youtube.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,54 @@ module Invidious::Frontend::Comments
END_HTML
else
html << <<-END_HTML
<div class="pure-g video-iframe-wrapper">
<iframe class="video-iframe" src='/embed/#{attachment["videoId"]?}?autoplay=0'></iframe>
</div>
<a href="/watch?v=#{attachment["videoId"]}">
<div class="thumbnail">
END_HTML

if thin_mode
html << %(<img loading="lazy" class="thumbnail" src="/vi/)
html << attachment["videoId"]
html << %(/mqdefault.jpg" alt="" />)
else
html << %(<div class="bottom-right-overlay">)
end
Comment on lines +109 to +115
Copy link
Member

@Fijxu Fijxu Dec 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if thin_mode
html << %(<img loading="lazy" class="thumbnail" src="/vi/)
html << attachment["videoId"]
html << %(/mqdefault.jpg" alt="" />)
else
html << %(<div class="bottom-right-overlay">)
end
if thin_mode
html << %(<div class="bottom-right-overlay">)
else
html << %(<img loading="lazy" class="thumbnail" src="/vi/)
html << attachment["videoId"]
html << %(/mqdefault.jpg" alt="" />)
end

Logic issue, when thin_mode is true IT SHOULDN'T show a thumbnail.


html << <<-END_HTML
<div class="bottom-right-overlay">
<p class="length">#{recode_length_seconds(attachment["lengthSeconds"].as_i)}</p>
</div>
</div>
<div class="video-card-row">
<p style="width:100%">#{attachment["title"]}</p>
</div>
</a>
END_HTML

if !attachment["authorId"].as_s.empty?
if attachment["authorVerified"].as_bool
verified_icon_html = %(&nbsp;<i class="icon ion ion-md-checkmark-circle"></i>)
else
verified_icon_html = ""
end

html << <<-END_HTML
<a href="/channel/#{attachment["authorId"]}">
<div class="video-card-row flexible">
<p class="channel-name">
<b style="width:100%">#{attachment["author"]}</b>#{verified_icon_html}
</p>
</div>
</a>
END_HTML
else
html << <<-END_HTML
<div class="video-card-row flexible">
<p class="channel-name">
<b style="width:100%">#{attachment["author"]}</b>
</p>
</div>
END_HTML
end
end
when "multiImage"
html << <<-END_HTML
Expand Down
Loading