Closed
Conversation
Owner
|
Hi! Thank you for a pull request. Unfortunately, I'm a little busy right now. I'll try to take a look at the weekend. |
Owner
|
Hi! I did not forget about you pull request, but I'm still a little busy right now. |
Author
|
No worries! Take your time😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for bringing this awesome project to life!
I was working on a project and came up to this kind of code where
a_settingandb_settingcontrol the parameters ofsome_injectable_function:...but I thought this will get more complex and uneasy to read if there's more conditions and parameters. I think this problem comes from not having ways to explicitly set a parameter to be injected.
I implemented a MARKER object that the injector will detect and replaces with the injected value. With this PR, you would be able to write it like
or
Comments well appreciated! Please tell me if there's any flaw in my code.