Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve slugify that isn't working with some cases #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve slugify that isn't working with some cases #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/src/slugify.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'replacements.dart';

final _dupeSpaceRegExp = RegExp(r'\s{2,}');
final _dupeSpaceRegExp = RegExp(r'[-\s]+');
final _punctuationRegExp = RegExp(r'[^\w\s-]');

/// Converts [text] to a slug [String] separated by the [delimiter].
Expand All @@ -17,10 +17,10 @@ String slugify(String text, {String delimiter = '-', bool lowercase = true}) {
replacements.forEach((k, v) => slug = slug.replaceAll(k, v));

slug = slug
// Condense whitespaces to 1 space.
.replaceAll(_dupeSpaceRegExp, ' ')
// Remove punctuation.
.replaceAll(_punctuationRegExp, '')
// Condense whitespaces to 1 space.
.replaceAll(_dupeSpaceRegExp, ' ')
// Replace space with the delimiter.
.replaceAll(' ', delimiter);

Expand Down