Skip to content

WIP: support language: dart #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Lutra-Fs wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

WIP: support language: dart #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b2d1f33
Add Dart language support (#51)
claude Nov 23, 2025
cff5509
Fix Dart implementation for Windows compatibility
claude Nov 23, 2025
e4a4406
Add diagnostic logging for Dart PATH detection on Windows
claude Nov 23, 2025
0fbd416
Fix Dart executable path resolution in Cmd calls
claude Nov 23, 2025
21d3beb
Fix Dart additional_dependencies to create proper pubspec.yaml
claude Nov 23, 2025
49538c5
Add Dart SDK version filter for snapshot tests
claude Nov 23, 2025
50f28ce
Copy package_config.json to work_dir for Dart package resolution
claude Nov 23, 2025
3daa29c
Remove diagnostic test for Dart detection
claude Nov 23, 2025
1906133
Add Dart SDK to CI test environments
claude Nov 23, 2025
f2246e2
Merge branch 'master' into claude/investigate-issue-51-01Canof7ZHmjs9…
Lutra-Fs Nov 23, 2025
89ce3f8
Fix rustfmt and clippy issues for Dart implementation
claude Nov 23, 2025
18ca07c
Merge branch 'master' into claude/investigate-issue-51-01Canof7ZHmjs9…
Lutra-Fs Nov 23, 2025
b7f7298
Use stdout only for dart --version output
claude Nov 23, 2025
80031a1
Refactor Dart implementation to align with codebase patterns
claude Nov 23, 2025
2c9b41d
Minor tweaks
j178 Nov 23, 2025
7baaf36
Add dart compile exe support to align with pre-commit
claude Nov 23, 2025
b01adb2
Enable with_pubspec_and_dependencies test
claude Nov 23, 2025
0264c93
Fix: Support compiling executables for local hooks
claude Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ env:
RUBY_VERSION: "3.4"
LUA_VERSION: "5.4"
LUAROCKS_VERSION: "3.12.2"
DART_VERSION: "3.10.1"

jobs:
lint:
Expand Down Expand Up @@ -221,6 +222,11 @@ jobs:
with:
ruby-version: ${{ env.RUBY_VERSION }}

- name: "Install Dart"
uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 # v1.6.5
with:
sdk: ${{ env.DART_VERSION }}

- name: "Cargo test"
run: |
cargo llvm-cov nextest \
Expand Down Expand Up @@ -301,6 +307,11 @@ jobs:
with:
ruby-version: ${{ env.RUBY_VERSION }}

- name: "Install Dart"
uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 # v1.6.5
with:
sdk: ${{ env.DART_VERSION }}

- name: "Cargo test"
run: |
cargo nextest show-config test-groups
Expand Down Expand Up @@ -392,6 +403,11 @@ jobs:
with:
ruby-version: ${{ env.RUBY_VERSION }}

- name: "Install Dart"
uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672 # v1.6.5
with:
sdk: ${{ env.DART_VERSION }}

- name: "Cargo test"
working-directory: ${{ env.PREK_WORKSPACE }}
run: |
Expand Down
3 changes: 3 additions & 0 deletions crates/prek-consts/src/env_vars.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ impl EnvVars {
pub const LUA_PATH: &'static str = "LUA_PATH";
pub const LUA_CPATH: &'static str = "LUA_CPATH";

// Dart related
pub const PUB_CACHE: &'static str = "PUB_CACHE";

// Ruby related
pub const GEM_HOME: &'static str = "GEM_HOME";
pub const GEM_PATH: &'static str = "GEM_PATH";
Expand Down
2 changes: 1 addition & 1 deletion docs/todo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The original pre-commit supports hooks written in 10+ languages. The table below
| node | ✅ Supported | — | |
| golang | ✅ Supported | — | |
| lua | ✅ Supported | — | |
| dart | ✅ Supported | — | |
| system | ✅ Supported | — | |
| script | ✅ Supported | — | |
| pygrep | ✅ Supported | — | |
Expand All @@ -27,7 +28,6 @@ The original pre-commit supports hooks written in 10+ languages. The table below
| rust | 🚧 Planned | [#44](https://github.com/j178/prek/issues/44) | |
| conda | 🚧 Planned | [#52](https://github.com/j178/prek/issues/52) | |
| coursier | 🚧 Planned | [#53](https://github.com/j178/prek/issues/53) | |
| dart | 🚧 Planned | [#51](https://github.com/j178/prek/issues/51) | |
| dotnet | 🚧 Planned | [#48](https://github.com/j178/prek/issues/48) | |
| haskell | 🚧 Planned | — | |
| julia | 🚧 Planned | — | |
Expand Down
Loading