fix: reuse current window for SSH connections instead of opening new one#496
Merged
Conversation
When connecting to a remote workspace via SSH, the default behavior now navigates the current window to the new workspace (matching VS Code's QuickOpen behavior where Enter reuses the window). A new window is only opened when explicitly requested (Ctrl+click or forceNewWindow option). Also fixes session restore for SSH windows by adding decodeURIComponent() when extracting the remote authority from vscode-remote:// URIs. The percent-encoded authority (e.g. ssh-remote%2Braspi) was not being decoded, causing the remote connection to hang on "Opening Remote...". Changes handleExpectedShutdown visibility from private to protected in BrowserHostService so TauriHostService can call it before navigation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forceNewWindowoption still opens a new window as beforedecodeURIComponent()was missing when extracting the remote authority fromvscode-remote://URIs, causing the app to hang on "Opening Remote..." after restarthandleExpectedShutdownvisibility fromprivatetoprotectedinBrowserHostServiceto allowTauriHostServiceto flush state before navigationTest plan
compile-check-ts-native)cargo build)🤖 Generated with Claude Code