fix: detect Windows shell profiles with absolute paths and support default profile selection#502
Merged
Merged
Conversation
…fault profile selection Shell profile detection used bare executable names on Windows which prevented suggestions from appearing in terminal settings. Switched to absolute paths covering PowerShell, pwsh (MSI/Store/Scoop), Git Bash, cmd, and WSL. Added case-insensitive path comparison for Windows default shell detection. Merged config profiles with detected profiles so that getDefaultProfile() correctly finds user-configured defaults. Co-Authored-By: Claude Opus 4.7 <[email protected]>
- Use strict !== for null check (eqeqeq rule) - Replace 'in' operator with hasOwnProperty (code-no-in-operator rule) Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"powershell.exe") which prevented shell candidate suggestions from appearing interminal.integrated.defaultProfile.windowssettingsComSpecmay returnC:\WINDOWS\...while candidates use%windir%\System32\...)getProfiles()so thatgetDefaultProfile()correctly finds user-configured defaults (it filters!e.isAutoDetected)getProfileIcon()mapping shell names to Codicon terminal iconsTest plan
terminal.integrated.defaultProfile.windows— verify suggestion list shows detected shells--login -iisDefaultis correctly set for ComSpec shell (cmd.exe) on Windows🤖 Generated with Claude Code