fix: strip UNC path prefix from resource_dir extensions path for Bun compatibility#514
Merged
fix: strip UNC path prefix from resource_dir extensions path for Bun compatibility#514
Conversation
…compatibility On Windows, Tauri's resource_dir() may return paths with the \\\\?\\ extended-length prefix. This prefix breaks Bun's require() in the Extension Host, preventing built-in extensions (git-base, github-authentication) from activating. Apply dunce::canonicalize() to all three resource directory fallback paths, consistent with the existing CWD-based path resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, Tauri's
resource_dir()may return paths with the\\?\extended-length prefix. This prefix breaks Bun'srequire()in the Extension Host, preventing built-in extensions (git-base,github-authentication,Git,GitHub) from activating in production builds.This is the same class of issue fixed in #494 (commit d65214d) for CWD-based paths, but the
resource_dir()fallback paths (used in production/packaged builds) were missed.Related Issue
No existing issue — this is a follow-up fix for the partial resolution in #494.
Changes
dunce::canonicalize()to all threeresource_dir()fallback paths inresolve_extensions_dir():_up_/.build/extensions(packaged extensions)_up_/extensions(legacy path)extensions(direct path)How to Test
cargo tauri build)app.logno longer containsCannot find module '\\?\...'errors