fix: resolve TDZ error and hostname typo in ExtHost WebSocket server#515
Merged
Conversation
- Move setTimeout after Bun.serve() so server is always initialized before the timeout callback can reference it (avoids TDZ) - Fix hostname typo from '127.0.1' to '127.0.0.1' that caused Bun.serve() to fail synchronously on binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs in
exthostWsServer.tsthat prevented extensions from loading in dev mode:'127.0.1'→'127.0.0.1'— causedBun.serve()to fail synchronously on bindingsetTimeoutafterBun.serve()soserveris always initialized before the timeout callback can reference itChanges
src/vs/workbench/api/node/exthostWsServer.tsBun.serve()now executes beforesetTimeoutregistration'127.0.1'to'127.0.0.1'server!.port→server.port)Testing
npm run compile-check-ts-native(no TS errors)npm run tauri:devwin— extensions load correctly