Fixes Error - Uncaught Exception Error: write EIO #92 #118
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| import fs from 'fs' | ||
| import path from 'path' | ||
| import { app } from 'electron' | ||
|
|
||
| class SafeLogger { | ||
| private logDir: string | ||
| private mainLogPath: string | ||
| private shortcutLogPath: string | ||
|
|
||
| constructor() { | ||
| // Initialize log directory | ||
| this.logDir = path.join(app.getPath('userData'), 'logs') | ||
| this.mainLogPath = path.join(this.logDir, 'main-events.log') | ||
| this.shortcutLogPath = path.join(this.logDir, 'shortcut-events.log') | ||
|
|
||
| // Create logs directory if it doesn't exist | ||
| this.ensureLogDirectory() | ||
| } | ||
|
|
||
| private ensureLogDirectory(): void { | ||
| try { | ||
| if (!fs.existsSync(this.logDir)) { | ||
| fs.mkdirSync(this.logDir, { recursive: true }) | ||
| } | ||
| } catch (error) { | ||
| // Silently fail - we can't log the error since we're creating the logger | ||
| } | ||
| } | ||
|
|
||
| private formatLogMessage(level: string, source: string, ...args: any[]): string { | ||
| const timestamp = new Date().toISOString() | ||
| const message = args.map(arg => | ||
| typeof arg === 'object' ? JSON.stringify(arg, null, 2) : String(arg) | ||
| ).join(' ') | ||
| return `[${timestamp}] [${level}] [${source}] ${message}\n` | ||
| } | ||
|
|
||
| private writeToFile(filePath: string, message: string): void { | ||
| try { | ||
| // Check size limit before writing | ||
| this.checkAndClearIfOverLimit() | ||
| fs.appendFileSync(filePath, message, 'utf8') | ||
| } catch (error) { | ||
| // Silently fail - we can't use console.log here as it would cause the same issue | ||
|
There was a problem hiding this comment. This silent failing is fine as everything would be in the log file already. There was a problem hiding this comment. Agreed, this silent failing is appropriate here since if we can't write to the log file, using console.log would defeat the purpose and potentially cause the original EIO error we're trying to solve. |
||
| } | ||
| } | ||
|
|
||
| // Main process logging | ||
| mainLog(...args: any[]): void { | ||
| const message = this.formatLogMessage('INFO', 'MAIN', ...args) | ||
| this.writeToFile(this.mainLogPath, message) | ||
| } | ||
|
|
||
| mainError(...args: any[]): void { | ||
| const message = this.formatLogMessage('ERROR', 'MAIN', ...args) | ||
| this.writeToFile(this.mainLogPath, message) | ||
| } | ||
|
|
||
| mainWarn(...args: any[]): void { | ||
| const message = this.formatLogMessage('WARN', 'MAIN', ...args) | ||
| this.writeToFile(this.mainLogPath, message) | ||
| } | ||
|
|
||
| // Shortcut process logging | ||
| shortcutLog(...args: any[]): void { | ||
| const message = this.formatLogMessage('INFO', 'SHORTCUT', ...args) | ||
| this.writeToFile(this.shortcutLogPath, message) | ||
| } | ||
|
|
||
| shortcutError(...args: any[]): void { | ||
| const message = this.formatLogMessage('ERROR', 'SHORTCUT', ...args) | ||
| this.writeToFile(this.shortcutLogPath, message) | ||
| } | ||
|
|
||
| shortcutWarn(...args: any[]): void { | ||
| const message = this.formatLogMessage('WARN', 'SHORTCUT', ...args) | ||
| this.writeToFile(this.shortcutLogPath, message) | ||
| } | ||
|
|
||
| // Generic logging method | ||
| log(source: string, level: 'INFO' | 'ERROR' | 'WARN', ...args: any[]): void { | ||
| const logPath = source === 'SHORTCUT' ? this.shortcutLogPath : this.mainLogPath | ||
| const message = this.formatLogMessage(level, source, ...args) | ||
| this.writeToFile(logPath, message) | ||
| } | ||
|
|
||
| // Check total log directory size | ||
| private getDirectorySize(): number { | ||
| try { | ||
| let totalSize = 0 | ||
| const files = fs.readdirSync(this.logDir) | ||
|
|
||
| files.forEach(file => { | ||
| const filePath = path.join(this.logDir, file) | ||
| const stats = fs.statSync(filePath) | ||
| totalSize += stats.size | ||
| }) | ||
|
|
||
| return totalSize | ||
| } catch (error) { | ||
| return 0 | ||
| } | ||
| } | ||
|
|
||
| // Clear all logs if size exceeds 1GB | ||
| private checkAndClearIfOverLimit(): void { | ||
| try { | ||
| const sizeLimit = 1024 * 1024 * 1024 // 1GB in bytes | ||
| const currentSize = this.getDirectorySize() | ||
|
|
||
| if (currentSize > sizeLimit) { | ||
| // Clear all log files | ||
| const files = fs.readdirSync(this.logDir) | ||
| files.forEach(file => { | ||
| const filePath = path.join(this.logDir, file) | ||
| try { | ||
| fs.unlinkSync(filePath) | ||
| } catch (error) { | ||
| // Silently fail for individual file deletion | ||
| } | ||
| }) | ||
|
|
||
| // Log the cleanup action | ||
| const message = this.formatLogMessage('INFO', 'SYSTEM', `Log directory cleared due to size limit (${(currentSize / 1024 / 1024).toFixed(2)}MB exceeded 1GB limit)`) | ||
| this.writeToFile(this.mainLogPath, message) | ||
| } | ||
| } catch (error) { | ||
| // Silently fail | ||
|
There was a problem hiding this comment. This can be logged normally There was a problem hiding this comment. You're right, since this would be called during normal operation (not during logger initialization), we can safely log this error using our own logging methods. |
||
| } | ||
| } | ||
| } | ||
|
|
||
| // Create singleton instance | ||
| export const safeLogger = new SafeLogger() | ||
|
|
||
| // Convenience functions for backward compatibility | ||
| export const safeLog = (...args: any[]) => safeLogger.mainLog(...args) | ||
| export const safeError = (...args: any[]) => safeLogger.mainError(...args) | ||
| export const safeWarn = (...args: any[]) => safeLogger.mainWarn(...args) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should silently fail this - if this fails there is no way of figuring out what went wrong before or after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right. If the log directory creation fails, we should at least attempt to use a fallback location or provide some indication of the failure. I'll update this to try a fallback directory and use stderr as a last resort.