Skip to content

All 3 approaches added #73 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShubhamGawai-96
Copy link

No description provided.

@us1415 us1415 requested a review from Copilot May 6, 2025 14:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the messaging in the ProcessingHelper to reflect that three solution approaches—including a brute-force better approach and an optimal solution—are now being generated.

  • Updated progress status messaging to include "brute-force better-approach".
  • Modified the prompt to instruct generation of both brute-force and optimal solutions.
  • Updated system message text for clarity, though with minor formatting issues.
Comments suppressed due to low confidence (1)

electron/ProcessingHelper.ts:804

  • [nitpick] The text 'Brute-Force Approach Better Approach' is redundant; consider revising it to a consistent phrasing such as 'Brute-Force Better Approach & Optimal solution' for clarity.
text: `You are an expert coding interview assistant. Provide Brute-Force Approach Better Approach & Optimal solution with detailed explanations for this problem:\n\n${promptText}`

@@ -777,7 +777,7 @@ Your solution should be efficient, well-commented, and handle edge cases.
const solutionResponse = await this.openaiClient.chat.completions.create({
model: config.solutionModel || "gpt-4o",
messages: [
{ role: "system", content: "You are an expert coding interview assistant. Provide clear, optimal solutions with detailed explanations." },
{ role: "system", content: "You are an expert coding interview assistant.Provide Brute-Force Better Approach & Optimal solutions with detailed explanations." },
Copy link
Preview

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing space after the period in the system message; please insert a space (i.e., 'assistant. Provide') for better readability.

Suggested change
{ role: "system", content: "You are an expert coding interview assistant.Provide Brute-Force Better Approach & Optimal solutions with detailed explanations." },
{ role: "system", content: "You are an expert coding interview assistant. Provide Brute-Force Better Approach & Optimal solutions with detailed explanations." },

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

@bhaumikmaan bhaumikmaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand the need to change it the way you did - but it requires a collective decision that do we digress the model from a singular definitive solution to multiple solutions that "may" not be correct (AI Behavior)


I'm now getting all three approaches on my linux system when i remove the comma.

Which comma are you talking about here in #73? Please add more supporting screenshots as well please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants