Draft
Conversation
Author
|
@jacerhea please advise what would be the minimum baseline for this PR to be considered. Test suites don't seem to be very usable (integration tests depend on a specific API token and hard-coded role ids that prevent using any other account). |
Owner
|
I think I'll just need to do some spot checking with my own account. Is the PR ready to be reviewed? |
Owner
|
Any positive change is a welcome PR. This is the first PR to be requested, and I haven't touched this repo in a few years except for the occasional bug fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be great if others can contribute documenting properties and method, unit tests, etc.
Putting this here as a placeholder. @jacerhea please advise what would be the minimum baseline for this PR to be considered.