Skip to content

feat(browser): add function form page.evaluate#1508

Merged
jackwener merged 1 commit into
mainfrom
feat/evaluate-function-overload
May 12, 2026
Merged

feat(browser): add function form page.evaluate#1508
jackwener merged 1 commit into
mainfrom
feat/evaluate-function-overload

Conversation

@jackwener
Copy link
Copy Markdown
Owner

Summary

  • add page.evaluate(fn, ...args) overload for daemon-backed and direct-CDP pages
  • serialize function args through JSON.stringify and reject string eval with stray args
  • keep existing string eval / wrapForEval behavior for current adapters
  • migrate twitter/following href + API fetch snippets to function form and update adapter-author docs

Verification

  • npm test -- --run src/browser/utils.test.ts src/browser/page.test.ts src/browser/base-page.test.ts src/browser/article-extract.test.ts clis/twitter/following.test.js
  • npm run typecheck
  • npm run build
  • npm run docs:build
  • npm run check:typed-error-lint
  • npm run check:silent-column-drop
  • git diff --check

@jackwener jackwener force-pushed the feat/evaluate-function-overload branch from 6ed579e to 14b1dc8 Compare May 12, 2026 13:36
@jackwener jackwener merged commit a77e058 into main May 12, 2026
13 checks passed
@jackwener jackwener mentioned this pull request May 13, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant