[codex] fix xiaohongshu download image order#1515
Draft
Scofy0123 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xiaohongshu downloadRoot Cause
xiaohongshu/downloadpreviously collected images from carousel-related DOM selectors and stored them in aSet. That preserved DOM discovery order, not necessarily the order shown in the platform carousel. Hidden slides, preloaded slides, duplicated carousel nodes, or responsive rendering can make the visible cover appear after another DOM image, causing filenames like<noteId>_1.jpgto be misleading.The shared
downloadMediahelper simply names files by the media array index it receives, so the adapter needs to pass media in platform display order.Validation
npm run test:adapter -- clis/xiaohongshu/download.test.jsnpm run test:adapter -- clis/xiaohongshu/*.test.jsnpm run typecheck