money for nothing and your odepacks for free#16
Closed
Zaneham wants to merge 11 commits intojacobwilliams:masterfrom
Closed
money for nothing and your odepacks for free#16Zaneham wants to merge 11 commits intojacobwilliams:masterfrom
Zaneham wants to merge 11 commits intojacobwilliams:masterfrom
Conversation
Zaneham
changed the title
Author
|
Just an fyi test_methods.f90 is different from the original specs. It checks against analytical solutions with explicit tolerances. The core test is still the same as in documentation (at least how I read it). This is for compatibility with new hardware/compilers and anything else that may impact the original algorithm. |
Author
|
Sorry, I couldn't help myself and added some regression tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnrm2BLAS calls with Fortran 2008norm2()intrinsicChanges
References
All changes cite original ODEPACK documentation:
Test Results
All 8 tests pass (7 original examples + new test_methods suite)
Merry Christmas from New Zealand!