Works on M1 Mac, CD/CI added, builds dependent images, linted #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix .gitignore to ignore the whole Dataset and the build artifacts in ./ORB_SLAM3 Linted README.md and add Mac Xhost instructions Fixes to allow this to run properly on a Mac and updates to the _cpu shell script in _rich for testing
Install the optional pre-commit you and install with `pre-commit install` pick up linting for Dockerfiles and README.md Update to README.md on Mac M1 support in build_image.sh Shfmt'ing of shell scripts does not pass all lints
now uses the ORG for the pull
Add makefile and github action Adding xeyes to test X11 connection Dockerfile.rich is a hadolint clean and optimized build Makefile gets ORG, IMAGE and DOCKEFILE parameters Fixes for build_image to build either cuda or gpu
the system depends on a ros-docker-gui and this is not pushed nor built so add this as a submodule fix: using netdrone's ros-docker-gui as the other repo does not push any images ros-docker-gui builds melodic and pushes to your directory Dockerfile_rich setup and cpu now builds Makefile lets you change Dockerfile prefix so you can use experimental ones and ./build_image.sh is updated to handle this as well
Finished rebuild of cpu container for ros Finished build of build container X-11 working Next: debug ORB_SLAM3 make download checks for directory and zip file and only does a download if they are not present lib no longer has a test target
Makefile cuts the build container into pieces works with the modified _rich_cpu.sh
Moved the test files named _rich to the base ones and verified the whole things works with make all
Build works on Mac M1 in docker container for opencv 3.2 patched release
Points out the limitations of this build and points out the work by LMWafers to get it running in another repo
|
Thanks for the pull request. I will look into it soon and let you know. I do not have mac though. |
|
Np. I am getting an Ubuntu machine and will debug that too. Also have u tried this with v1.0 of orb slam3? And opencv 4.x not to mention python 3.x? |
|
That's great. I will update it to the latest. I'm quite happy that they updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some things to make this a production system specifically:
side. It looks like you build completely from an nvidia image on the cuda
side, but the cpu only build does not work as there is no image to pull from
downstream repo, but it doesn't look like docker-gui is being maintained
much so forked it.
get more stability.
various build scripts. Added flags so build_container_cpu does not always
destroy all the data and can restart. See make help for details
like they might work the v1 and OpenCV 4 respectively