addressed review comments

jaipreet-s · Nov 30, 2019 · 977caab · 977caab
1 parent ae603fd
commit 977caab
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/MANIFEST.in b/MANIFEST.in
@@ -3,8 +3,6 @@ include README.md
 
 include setupbase.py
 
-include jupyterlab_git/labextension/*.tgz
-
 # Patterns to exclude from any directory
 global-exclude *~
 global-exclude *.pyc

diff --git a/package.json b/package.json
@@ -14,8 +14,8 @@
   "scripts": {
     "build": "jlpm install && tsc",
     "build:labextension": "jlpm build && jlpm clean:labextension && mkdirp jupyterlab_git/labextension && cd jupyterlab_git/labextension && npm pack ../..",
-    "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
-    "clean:more": "jlpm clean && rimraf build && rimraf dist",
+    "clean": "rimraf lib tsconfig.tsbuildinfo",
+    "clean:more": "jlpm clean && rimraf build dist MANIFEST",
     "clean:labextension": "rimraf jupyterlab_git/labextension",
     "clean:slate": "jlpm clean:more && jlpm clean:labextension && rimraf node_modules",
     "watch": "tsc -w",

diff --git a/setup.py b/setup.py
@@ -1,5 +1,7 @@
-"""
-Setup Module to setup Python Handlers (Git Handlers) for the Git Plugin.
+"""Setup Module to setup Python serverextension for the jupyterlab git
+extension. For non-dev installs, will also automatically
+build (if package.json is present) and install (if the labextension exists,
+eg the build succeeded) the corresponding labextension.
 """
 from pathlib import Path
 from subprocess import CalledProcessError