Replace elseif
s with early returns in Connection
#153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes replacing all
elseif
branches in the generatedConnection
class with early returns.This is in preparation for #152, which has the primary goal of removing a duplicate check
bunny/src/Connection.php
Lines 342 to 347 in 873ec47
The problem there is that this requires removing an
if
branch and converting anelseif
branch to anif
branch.Removing
elseif
branches in the first place will make this a lot easier.