Add missing DNAD.fpp test sample - #377
Open
krystophny wants to merge 2 commits into
Open
Conversation
test_parser.py and test_transform.py reference test/samples/DNAD.fpp, which was never committed because .gitignore excludes *.fpp globally, so both test_parse_dnad cases fail with FileNotFoundError on a clean checkout. Un-ignore .fpp files under test/samples and add the sample from the DNAD project (github.com/joddlehod/dnad, dnad.F90), whose structure matches the assertions in both tests.
numpy 2.5 ships only manylinux_2_28 wheels, so the cp312 and cp313 Linux wheel builds fall back to compiling numpy from source inside the default manylinux2014 container, where gcc 10.2.1 fails numpy's 'requires GCC >= 10.3' check. Build in the manylinux_2_28 image, whose toolchain is new enough and where numpy wheels install directly.
Contributor
Author
|
Wheel CI failed for cp312/cp313 on Linux: numpy 2.5 ships only manylinux_2_28 wheels, so the default manylinux2014 container built numpy from source and failed its gcc >= 10.3 check. Included a one-line workflow fix building Linux wheels in the manylinux_2_28 image. |
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_parser.py::TestParser::test_parse_dnadandtest_transform.py::TestTransform::test_parse_dnadreferencetest/samples/DNAD.fpp, which was never committed because.gitignoreexcludes*.fppglobally. Both tests fail withFileNotFoundErroron a clean checkout. This un-ignores.fppfiles undertest/samplesand adds the sample from the DNAD project (https://github.com/joddlehod/dnad,dnad.F90), whose structure matches the assertions in both tests. The file's license permits redistribution, and an older DNAD version already ships inexamples/cylinder/DNAD.f90.Verification
Test fails on main
Test passes after fix
@jameskermode ready for review.