Possible fix for broken callbacks#35
Closed
elon-gs wants to merge 1 commit intojamiebuilds:masterfrom
elon-gs:master
Closed
Possible fix for broken callbacks#35elon-gs wants to merge 1 commit intojamiebuilds:masterfrom elon-gs:master
elon-gs wants to merge 1 commit intojamiebuilds:masterfrom
elon-gs:master
Conversation
ehaynes99
approved these changes
Apr 19, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm having the same problem and this commit fixed it. @jamiebuilds Probably is a big bug, if you need some help to test it, i'll be happy to try. |
|
Created a CodeSandbox demonstrating the issue: https://codesandbox.io/s/k9n8x5p447. Thanks for all the hard work that goes into building and maintaining this! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callbacks aren't working for me with 2.0.2. I believe the condition I've changed was to blame.