-
Notifications
You must be signed in to change notification settings - Fork 213
Update PebbleKkt.Android and com.google.android.gms:play-services-location version #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jstevensog
wants to merge
23
commits into
jamorham:master
Choose a base branch
from
jstevensog:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freshen up
Update to latest commits
Bringing my branch up to date
refresh of my personal repo with Head
Update my repo
UPdate from jmorham
Update my master
Update 20200605
Update from master
…jamorham-master
Freshen my repo to Head repo
Note, this does NOT fix the PebbleKit.isWatchConnected(this.context) always returning false issue. That appears to be a bug in tbe Pebble app.
Owner
|
Hi, yes I can just make those gradle dependency modifications. Can you explain what the impact of that change is though? |
Contributor
Author
|
The PebbleKit update just moved us ready to support the new Pebble models.
The other was required to commit the PebbleKit update. The Android studio
wouldn't allow the commit unless I moved to a later supported version,
saying that it wouldn't be allowed in the Google app store, so I figured
we'd be best to move to it. But I'll leave that up to you.
Cheers
John Stevens
"You are how you live, not what you have."
…On Sun, 4 Jan 2026, 01:32 JamOrHam, ***@***.***> wrote:
*jamorham* left a comment (jamorham/xDrip-plus#272)
<#272 (comment)>
Hi, yes I can just make those gradle dependency modifications. Can you
explain what the impact of that change is though?
—
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCCZ42V6QMDYPNVUWMEKVL4E7HJBAVCNFSM6AAAAACQSYSHQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBXGA4TENZXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change here is build.gradle file. All others can be ignored.
This updates the PebbleKit.Android implementaiton version and the com.google.android.gms:play-services-location implementation version so the IDE would push this to the repo.
If you do not want to merge this (and I totally understand why) just change the following lines in build.gradle to be these versions.
implementation 'com.google.android.gms:play-services-location:16.0.0'
implementation 'com.getpebble:pebblekit:4.0.1'
The rest of the commits are so old I have no idea what impact they would have.