Skip to content

Commit

Permalink
use coveralls native golang support (#89)
Browse files Browse the repository at this point in the history
* use coveralls native golang support
* linter
  • Loading branch information
jandelgado authored Aug 19, 2024
1 parent c13ef2e commit 6f8d103
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
- master

env:
GO_VERSION: "1.22.4"
GO_LANG_CI_LINT_VERSION: "v1.59.1"
GO_VERSION: "1.22.5"
GO_LANG_CI_LINT_VERSION: "v1.60.1"

name: run tests
jobs:
Expand All @@ -35,7 +35,7 @@ jobs:
- name: create certificates
run: cd inttest/pki && ./mkcerts.sh
- name: Run RabbitMQ
run: cd inttest/rabbitmq && docker-compose up -d
run: cd inttest/rabbitmq && docker compose up -d
- name: Install Go
if: success()
uses: actions/setup-go@v4
Expand All @@ -46,13 +46,12 @@ jobs:
timeout 30 sh -c "while true; do curl -s http://guest:password@localhost:15672/api/exchanges/%2f/amq.topic && break || sleep 3; done"
- name: Run tests
run: make test
- name: Convert coverage.out to coverage.lcov
uses: jandelgado/gcov2lcov-action@v1
- name: Coveralls
uses: coverallsapp/github-action@v1.1.2
uses: coverallsapp/github-action@v2.3.0
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: coverage.lcov
file: coverage.out
format: golang
- name: Build release artifacts
if: env.build_artifacts # currently disabled
uses: goreleaser/goreleaser-action@v3
Expand Down
2 changes: 1 addition & 1 deletion cmd/rabtap/broker_info_renderer_dot.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,6 @@ func (s *brokerInfoRendererDot) renderNode(n interface{}, queueRendered map[stri
// https://www.graphviz.org/doc/info/lang.html
func (s *brokerInfoRendererDot) Render(rootNode *rootNode, out io.Writer) error {
res := s.renderNode(rootNode, map[string]bool{})
fmt.Fprintf(out, res.Text)
fmt.Fprint(out, res.Text)
return nil
}

0 comments on commit 6f8d103

Please sign in to comment.