Apply :has-bin-script less widely #252
Merged
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:has-bin-script was being applied in too many declare-* constructs so this has been dialed back. :has-exe has been added for the same purpose with the idea that :has-bin-script will be removed at some later point. The additional different name should help a bit with some of the points brought up in #1648 in the janet repository. The plan is to have a companion change to janet so both janet and spork will support :has-bin-script and :has-exe for a while.
sogaiu
force-pushed
the
tweak-has-bin-script
branch
from
467fad5 to
a987657
Compare
sogaiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to partially address #247.
:has-bin-scriptwas being applied in too manydeclare-*constructs so this has been dialed back.:has-exehas been added for the same purpose with the idea that:has-bin-scriptwill be removed at some later point. The additional different name should help a bit with some of the points brought up in #1648 associated with the janet repository.The plan is to have a companion change to janet so both janet and spork will support
:has-bin-scriptand:has-exefor a while.I hope some folks will try this and the companion change 🙏