parallelize bake#453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as Some-Bevy-Jam-7-Team/jam#10
Speeds up the light bake significantly, even in github actions.
On the systems I tested (7950x3d and on AWS c6a.4xlarge, c6i.4xlarge, c7i.4xlarge) this would run in like 10-15 seconds now instead of ~2-3 minutes.
I also noticed that it runs a bit faster when spawning twice as much workers as there are physical cores available, at least on the 7950x3d.
In containers this doesn't matter though since there is no difference there (e.g. 16/32 shows up as 32 cores) so I left it as is (also to always keep 1 core for system processes and advancing).