Test pop! #796
Merged
Test pop! #796
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes jank-lang#397.
E-A-Griffin
reviewed
Nov 11, 2025
| (deftest test-pop! | ||
|
|
||
| (testing "nominal cases" | ||
| (are [expected vec] (= expected (persistent! (pop! (transient vec)))) |
Collaborator
There was a problem hiding this comment.
Can we add a test for the count of the transient vector before coercing it to a persistent vector?
Member
There was a problem hiding this comment.
This is a gray area, since it could be considered testing count or testing transients in general, rather than pop!. The most important thing is that the value we get out of pop!, when turned persistent, is what we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #397.