Test uuid? #810
Merged
Test uuid? #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super7ramp
force-pushed
the
uuid-qmark
branch
from
1c55eea to
0dd8abe
Compare
E-A-Griffin
reviewed
Nov 16, 2025
super7ramp
force-pushed
the
uuid-qmark
branch
from
0dd8abe to
ce67a84
Compare
E-A-Griffin
approved these changes
Nov 16, 2025
Collaborator
E-A-Griffin
left a comment
E-A-Griffin
left a comment
There was a problem hiding this comment.
Great work, thanks again!
Contributor
|
Does using |
Member
I'm expecting all dialects to support it until we have some dialects which don't and then we need to make some hard calls. 😂 |
jeaye
requested changes
Nov 17, 2025
Comment on lines
15
to
17
| (when-var-exists read-string | ||
| (testing "more uuids" | ||
| (read-string "#uuid \"f81d4fae-7dec-11d0-a765-00a0c91e6bf6\""))) |
Member
There was a problem hiding this comment.
This isn't testing uuid?, so I think we can remove it.
Contributor
Author
There was a problem hiding this comment.
Oh yes, I forgot to wrap in (is (uuid? ...) 😄 Not very relevant anyway, will drop the case.
Contributor
Author
There was a problem hiding this comment.
Removed the case.
This closes jank-lang#556.
super7ramp
force-pushed
the
uuid-qmark
branch
from
ce67a84 to
0bb83e6
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #556.