Test parse-uuid tolerance to non-standard forms #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super7ramp
force-pushed
the
parse-uuid-non-standard-forms
branch
from
3f88fb4 to
873fdf9
Compare
E-A-Griffin
reviewed
Nov 16, 2025
| (are [expected s] (= #?(:clj expected :default nil) (parse-uuid s)) ; clj is permissive, others are strict | ||
| #uuid "00000000-0000-0000-0000-000000000000" "0-0-0-0-0" | ||
| #uuid "00000012-0034-0056-0078-000000000009" "12-34-56-78-9" | ||
| #uuid "00000005-0004-0003-0002-009000000001" "5-4-3-DEADBEEF0002-9000000001")) |
Collaborator
There was a problem hiding this comment.
this is really strange, great find! It may be a good idea to raise this as a separate clj bug so the language maintainers can decide whether deviating from Java's behavior here is preferred or not
Contributor
Author
There was a problem hiding this comment.
Thanks, will consider raising a bug to Clojure. (Honestly I doubt that a deviation from current behavior would happen at this point given the risk of breaking existing systems 😅 but still, it's worth noticing.)
E-A-Griffin
approved these changes
Nov 16, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing
uuid?, noticed some differences of behavior between platforms when parsing non-standard forms of UUIDs:UUID.fromStringis permissive, see e.g. JDK-8216407, JDK-8159339).This PR adds cases to capture these differences.