Add tests for hash-map, hash-set, and set

[rafonsecad]

No description provided.

[NoahTheDuke]

Maybe add nested calls? So (= {:a {:b {:c 1} :d 2}} (hash-map :a (hash-map :b (hash-map :c 1) :d 2))), etc.

I don't know how exactly to test it, but for example, you can't write #{(rand) (rand)} but you can write (hash-set (rand) (rand)), so maybe a test for that behavior?

[jeaye]

I think we should have a test which asserts that set removes duplicates.

Something like (set [1 2 3 1 2 3]).

[rafonsecad]

@jeaye, I just added (is (= #{1 2 3} (set [1 1 2 2 3 3 3])))

[jeaye]

Maybe add nested calls? So (= {:a {:b {:c 1} :d 2}} (hash-map :a (hash-map :b (hash-map :c 1) :d 2))), etc.

Sounds like a good thing to test.

I don't know how exactly to test it, but for example, you can't write #{(rand) (rand)} but you can write (hash-set (rand) (rand)), so maybe a test for that behavior?

We don't want to be using rand at all in these tests. Also, the lack of support for #{(foo) (foo)} is a reader feature, not a clojure.core feature. We don't need to test for it here.

[NoahTheDuke]

(rand) wasn't the best example, I just meant that the reader can't handle two of the same calls in a set or map literal, whereas the functions can handle it. That's fine tho.

[rafonsecad]

@NoahTheDuke, thanks for the comment, I just added (is (= {:a {:b {:c 1} :d 2}} (hash-map :a (hash-map :b (hash-map :c 1) :d 2))))

[jeaye]

Great job! Thanks so much for helping with these.