Skip to content

add tests for update #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025
Merged

add tests for update #92

merged 4 commits into from
Jul 23, 2025

Conversation

Flinner
Copy link
Contributor

@Flinner Flinner commented Jul 23, 2025

Hi!

I hope this covers everything


Start: 23/07/2025
Streak: 1 Day
Done: 1 Function

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
All committers have signed the CLA.

@Flinner
Copy link
Contributor Author

Flinner commented Jul 23, 2025

I apologize if the space formatting doesn't look good, I tried to align things visually, which some formatters don't like

@Flinner
Copy link
Contributor Author

Flinner commented Jul 23, 2025

I severely apologize for not testing cljs, the test will fail! I will try get things working ASAP!

Should be done now!

@Flinner
Copy link
Contributor Author

Flinner commented Jul 23, 2025

clj vs cljs

(apply identity '(1 2 3)) throws in clj but not cljs

Can't have laziness like so in cljs (it throws in clj)
(update (repeat 1) :k identity)

Copy link
Member

@jeaye jeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@jeaye jeaye merged commit bb43711 into jank-lang:main Jul 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants