-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #205 from jannis-baum/issue/204-upgrade-dependencies
Upgrade dependencies
- Loading branch information
Showing
5 changed files
with
1,114 additions
and
677 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# How to upgrade dependencies | ||
|
||
This document explains how to upgrade dependencies of Vivify. Only relevant for | ||
maintainers. | ||
|
||
## Process | ||
|
||
1. First commit: Run `yarn upgrade-interactive --latest`, go through the list, | ||
press <kbd>space</kbd> on all yellow and green entries, and confirm with | ||
<kbd>enter</kbd>. This should always be fine and not break anything (unless | ||
developers didn't properly flag some minor breaking change which often | ||
happens). | ||
2. Check that you can still `make install`, that `yarn lint` and `yarn dev` | ||
still work as they should, and that auto-refreshing with the Vim plugin | ||
works. You can use the files in [`tests/rendering`](../tests/rendering) to | ||
confirm. If something broke, fix the problems with one commit each. | ||
3. Next commit: Run `yarn upgrade-interactive --latest` again and install all | ||
red (breaking) `devDependencies`. | ||
4. Repeat *step 2*. | ||
5. Run `yarn upgrade-interactive --latest` again and go through the list of red | ||
(breaking) `dependencies`. Look up what the exact breaking change is and how | ||
it affects the project. With one commit each, upgrade the dependency and fix | ||
whatever (if anything) it broke as in *step 2*. | ||
6. Run `yarn deduplicate` and then `yarn` to keep only the newest required | ||
versions of dependencies and hopefully address all security issues the | ||
[Dependabot](https://github.com/jannis-baum/Vivify/security/dependabot) had | ||
found. | ||
7. Repeat *step 2* a final time, open a PR and ask another maintainer for a | ||
review. | ||
|
||
## Reviewing upgrade PRs | ||
|
||
You can follow along *step 2* above to check things are working and leave | ||
comments on the PR if they aren't. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.