Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl data without argument #15

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

jannis-baum
Copy link
Owner

Close #7

@jannis-baum
Copy link
Owner Author

Hey @tuurep this turned out easier than we thought :) Could you test that this also works on NeoVim?

I am not sure how long the file had to be do make it break before. I tested it now by duplicating our Markdown-basic test file to get to around 5000 lines and then the live reloading was still working. Duplicating it again made my whole Vim crash consistently, not sure if this is Vivify's fault but it probably doesn't matter anyways ^^

@tuurep

This comment was marked as resolved.

@tuurep

This comment was marked as resolved.

@tuurep
Copy link
Collaborator

tuurep commented Jul 28, 2024

Abort Abort

I had a scrap vivify.vim project folder in my plugin directory

Seems to be the cause of the above

Now I'll take another look 😄

@tuurep
Copy link
Collaborator

tuurep commented Jul 28, 2024

So yes, overall this seems very good

I tried to find about where it stops fully functioning when duplicating the whole of markdown-basic.md

Same observation, at 5000 lines still working fine (refresh, cursor sync and all),

but can't go up to 6000 lines. So somewhere between 5000 and 6000 it's no longer syncing, but still scrollable on the browser.

Also if I have an individual <p></p> with 1500 lines of lorem ipsum in it, same happens there. But note: at 1000 lines of lorem ipsum the sync is still working fine 😆

So to me seems like for sensible usage this is great.

I suppose it's possible to have a scenario where you work with 6000+ line md files, but I would definitely prioritize what we have here.

@tuurep
Copy link
Collaborator

tuurep commented Jul 28, 2024

Also there may have been cases where content refresh 'breaks' earlier than cursor sync does, if I'm not mistaken.

@tuurep
Copy link
Collaborator

tuurep commented Jul 28, 2024

I'd definitely approve this PR

And we could still make some fallback mechanisms for extreme scenarios (later) I suppose, but it seems niche.

@jannis-baum
Copy link
Owner Author

Nice, thanks as always for the rigorous testing!

I suppose it's possible to have a scenario where you work with 6000+ line md files, but I would definitely prioritize what we have here.

Yes I think the people that are working with 6000+ line md files have worse problems to deal with than auto-refresh not working😂


Will merge!

@jannis-baum jannis-baum merged commit e5a4f4a into main Jul 28, 2024
@jannis-baum jannis-baum deleted the issue/7-curl-data-without-argument branch July 28, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl data without argument
2 participants