Skip to content

Allow immediate mode authentication #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow immediate mode authentication #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe14491
Added immediate argument to authenticate
Jul 15, 2013
8a75820
0.3.2
Jul 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/passport-openid/strategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,10 @@ util.inherits(Strategy, passport.Strategy);
* 1.1.
*
* @param {Object} req
* @param {Boolean} immediate Set to true to check in immediate mode.
* @api protected
*/
Strategy.prototype.authenticate = function(req) {
Strategy.prototype.authenticate = function(req, immediate) {

if (req.query && req.query['openid.mode']) {
// The request being authenticated contains an `openid.mode` parameter in
Expand Down Expand Up @@ -245,7 +246,7 @@ Strategy.prototype.authenticate = function(req) {
if (!identifier) { return this.fail(new BadRequestError('Missing OpenID identifier')); }

var self = this;
this._relyingParty.authenticate(identifier, false, function(err, providerUrl) {
this._relyingParty.authenticate(identifier, immediate, function(err, providerUrl) {
if (err || !providerUrl) { return self.error(new InternalOpenIDError('Failed to discover OP endpoint URL', err)); }
self.redirect(providerUrl);
});
Expand Down
25 changes: 18 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
{
"name": "passport-openid",
"version": "0.3.1",
"version": "0.3.2",
"description": "OpenID authentication strategy for Passport.",
"keywords": ["passport", "openid", "auth", "authn", "authentication", "identity"],
"keywords": [
"passport",
"openid",
"auth",
"authn",
"authentication",
"identity"
],
"repository": {
"type": "git",
"url": "git://github.com/jaredhanson/passport-openid.git"
Expand All @@ -15,10 +22,12 @@
"email": "[email protected]",
"url": "http://www.jaredhanson.net/"
},
"licenses": [ {
"type": "MIT",
"url": "http://www.opensource.org/licenses/MIT"
} ],
"licenses": [
{
"type": "MIT",
"url": "http://www.opensource.org/licenses/MIT"
}
],
"main": "./lib/passport-openid",
"dependencies": {
"pkginfo": "0.2.x",
Expand All @@ -31,5 +40,7 @@
"scripts": {
"test": "NODE_PATH=lib node_modules/.bin/vows test/*-test.js test/**/*-test.js"
},
"engines": { "node": ">= 0.6.0" }
"engines": {
"node": ">= 0.6.0"
}
}