Auth feature - fourth iteration

src/components/islands/profile.jsx

@@ -79,4 +79,4 @@ export default function Profile({ isAuthed, userData, authUrl }) {
       </div>
     </div>
   );
-}
+}

src/lib/actions/do-auth.js

@@ -22,7 +22,6 @@ export default async function doAuth(astroGlobal) {
 
   /**
    * Generate OAuth Url to start authorization flow
-   * @todo improvement: store `state` in cookie for later retrieval/comparison with auth `state` in `github/oauth/callback`
    * @param {{ path: string }} state
    */
   function getAuthUrl(state) {
@@ -39,10 +38,16 @@ export default async function doAuth(astroGlobal) {
       if (otherStates.length > 0) parsedState += `|${otherStates}`;
     }
 
-    const { url } = app.oauth.getWebFlowAuthorizationUrl({
+    const { url, state: generatedState } = app.oauth.getWebFlowAuthorizationUrl({
       state: parsedState,
     });
 
+    cookies.set("oauthState", generatedState, {
+      expires: resolveCookieExpiryDate(600),
+      path: "/",
+      encode: (value) => encrypt(value),
+    });
+
     return url;
   }
 
@@ -60,6 +65,14 @@ export default async function doAuth(astroGlobal) {
       }
     }
 
+    const storedState = cookies.get("oauthState", {
+      decode: (value) => decrypt(value),
+    });
+
+    if (storedState !== searchParams.get("state")) {
+      throw new Error("Invalid OAuth state");
+    }
+
     const userOctokit = app.getUserOctokit({ token: accessToken.value });
     const { data } = await userOctokit.request("GET /user");
 

src/pages/api/github/oauth/callback.js

@@ -1,15 +1,27 @@
+import { decrypt } from "../../../../lib/utils/crypto.js";
+
 /**
  * GitHub OAuth Callback route handler
  * @param {import("astro").APIContext} context
  */
-export async function GET({ url: { searchParams }, redirect }) {
+export async function GET({ url: { searchParams }, redirect, cookies }) {
   const code = searchParams.get("code");
   const state = searchParams.get("state");
 
   if (!code || !state) {
     return new Response(null, { status: 400 });
   }
 
+  const storedState = cookies.get("oauthState", {
+    decode: (value) => decrypt(value),
+  });
+
+  if (storedState !== state) {
+    return new Response("Invalid OAuth state", { status: 400 });
+  }
+
+  cookies.delete("oauthState");
+
   const path = state.includes("path") && state.split("|")[0].split(":")[1];
 
   if (path) return redirect(`${path}?code=${code}`);

src/pages/logout.astro

@@ -1,8 +1,14 @@
 ---
-import doLogout from "../lib/actions/do-logout.js";
+import doAuth from "../lib/actions/do-auth.js";
 
 const { url: { searchParams }, redirect } = Astro;
 
-const { isLoggedOut } = await doLogout(Astro);
-if (isLoggedOut) return redirect(searchParams.get("return_to") || "/");
----
+const { isAuthed, getAuthUrl } = await doAuth(Astro);
+
+if (isAuthed) {
+  const { isLoggedOut } = await doAuth(Astro, { action: "logout" });
+  if (isLoggedOut) return redirect(searchParams.get("return_to") || "/");
+} else {
+  return redirect(getAuthUrl({ path: "/logout" }));
+}
+---