Ffmpeg improvements - #27
Conversation
|
Sorry I didn't notice this until now! Don't be shy to ping me at jtunney@gmail.com if I ever fall behind. I'll review this as soon as possible. Promise :) |
|
No rush, but thanks :) |
|
Needed this pull request to build against ffmpeg on latest arch build. |
| CHECK(frame_ = avcodec_alloc_frame()); | ||
| CHECK(frame_rgb_ = avcodec_alloc_frame()); | ||
| int rgb_bytes = avpicture_get_size(PIX_FMT_RGB24, width_, height_); | ||
| CHECK(frame_ = av_frame_alloc()); |
There was a problem hiding this comment.
This doesn't compile on my system.
You probably want to put something like this at the top of the file.
#if LIBAVUTIL_VERSION_INT <= AV_VERSION_INT(52, 9, 0)
#define av_frame_alloc avcodec_alloc_frame
#endif
|
Ok I took a look finally. If we can maintain backwards compatibility with what I have installed on my system (Ubuntu 14.04) then I'm happy. |
|
I'm so sorry, but when you get around to updating PR, you'll get a conflict rebasing this on master. I just migrated the project to GNU autotools. (That included moving movie.cc -> src/movie.cc.) This might actually help you deal with the breaking change in ffmpeg in a more proper manner. Maybe someone defined m4 macros for dealing with this. |
f9196d0 to
a875509
Compare
Compile against newer versions of ffmpeg, namely v3.0.1 Fixes jart#36
|
Is this update ok? I couldn't find an m4 macro, but it wasn't hard On 23/06/2016, Justine Tunney notifications@github.com wrote:
|
3 participants
I've been playing with using hipitext to output video streams. First I needed to change some symbols to compile against newer versions of ffmpeg, namely v3.0.1. Then I also needed to add some crude substr detection for URIs rather than just file extensions.
BTW, hiptext is waaaaaaaaay better than mplayer's libcaca etc.
The compiler still throws some warnings about deprecated symbols. Can/should the
Makefilepin to a specific version offfmpeg?Oh yes! Almost forgot. I first came across hiptext through rickrollrc! Happy days 😊