Refactor TEDAPI Vitals for Readability #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

mccahan wants to merge 2 commits into jasonacox:main from mccahan:chore/refactor-tedapi-vitals

Contributor

mccahan commented Mar 31, 2025

This is the most-easily-separable part of #153 - just pulling the vitals function out into a separate file.

Testing

Run this branch alongside an existing version
Open /vitals in each, and compare side-by-side
- I did this using a diff tool, and noted that the only difference between the two would be small measurement differences based on the timing of the data pull

N.B. I only have a PW3 to test on, none of the Neurio stuff, so I can't test those parts (though they should be essentially unchanged)

mccahan added 2 commits

March 23, 2025 15:01


          Refactor TEDAPI vitals

bb65cea


          Merge branch 'main' into chore/refactor-tedapi-vitals

e3cff4c

mccahan mentioned this pull request

Refactor TEDAPI __init__ for readability/code reuse #153

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet