Fetch the device list a 2nd time to make sure we have the local key #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonacox
reviewed
Mar 21, 2023
|
|
||
| # Find out if we should poll all devices | ||
| answer = input(subbold + '\nPoll local devices? ' + normal + '(Y/n): ') | ||
| if quicklist: |
jasonacox
reviewed
Mar 21, 2023
| getproperties(deviceid) | ||
| getdps(deviceid) | ||
| sendcommand(deviceid, commands) | ||
| sendcommand(deviceid, commands [, uri]) |
jasonacox
reviewed
Mar 21, 2023
| users[dev['uid']] = True | ||
| if users: | ||
| # we have at least 1 user id, so fetch the device list again to make sure we have the local key | ||
| # this also gets us the gateway_id for child devices |
|
Nice... I like the merge approach rather than scanning every ID with missing local_key's. Testing... Do we want to try to get any of the draft changes in on this release? I think this could go out as v1.12.1. |
|
To keep it clean (and small batch changes), I released this PR as v1.12.1 (see https://pypi.org/project/tinytuya/1.12.1/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305