Skip to content

Fix: MockDml correctly sets Lead fields on conversion #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonsiders merged 2 commits into from
Nov 14, 2025
Merged

Fix: MockDml correctly sets Lead fields on conversion #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46fb4e0
Fix: MockDml correctly sets Lead fields on conversion
jasonsiders Nov 14, 2025
d82820b
setting IsConverted=true
jasonsiders Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions source/classes/MockDml.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,13 +528,21 @@ global class MockDml extends Dml {
// This allows injected errors for Accounts/Contacts/Opps to be caught and handled appropriately
// 1. Simulate converting the lead
this.validateConvertedLead(leadToConvert);
this.generateMockResult(MockDml.CONVERTED, leadRecord, true);
// 2. Simulate creating an Account/Contact/Opportunity, if their Id wasn't already provided
this.simulateInsertIfNew(accountRecord);
this.simulateInsertIfNew(contactRecord);
this.simulateInsertIfNew(opportunityRecord);
// 3. Build & return the LeadConvertResult w/the resulting record ids
return (MockDml.LeadConvertResult) new MockDml.LeadConvertResult(leadRecord)
// 3. Set the converted record id fields on the Lead, which are normally read-only:
Lead convertedLead = (Lead) new MockRecord(leadRecord)
?.setField(Lead.ConvertedAccountId, accountRecord?.Id)
?.setField(Lead.ConvertedContactId, contactRecord?.Id)
?.setField(Lead.ConvertedOpportunityId, opportunityRecord?.Id)
?.setField(Lead.IsConverted, true)
?.setField(Lead.Status, leadToConvert?.getConvertedStatus())
?.toSObject();
this.generateMockResult(MockDml.CONVERTED, convertedLead, true);
// 4. Build & return the LeadConvertResult w/the resulting record ids
return (MockDml.LeadConvertResult) new MockDml.LeadConvertResult(convertedLead)
?.setId(accountRecord)
?.setId(contactRecord)
?.setId(opportunityRecord);
Expand Down
20 changes: 12 additions & 8 deletions source/classes/MockDmlTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,13 @@ private class MockDmlTest {
// **** TESTS **** //
@IsTest
private static void shouldMockLeadConvert() {
Map<Id, Lead> leads = new Map<Id, Lead>();
String convertedStatus = 'Foo!';
List<Database.LeadConvert> leadsToConvert = new List<Database.LeadConvert>();
for (Integer i = 0; i < TEST_SIZE; i++) {
Lead lead = (Lead) new MockRecord(Lead.SObjectType)?.withId()?.toSObject();
leads?.put(lead?.Id, lead);
Database.LeadConvert leadToConvert = new Database.LeadConvert();
leadToConvert?.setLeadId(lead?.Id);
leadToConvert?.setConvertedStatus('Foo!');
leadToConvert?.setConvertedStatus(convertedStatus);
leadsToConvert?.add(leadToConvert);
}

Expand All @@ -39,11 +38,16 @@ private class MockDmlTest {
for (Database.LeadConvertResult result : results) {
Assert.isTrue(result?.isSuccess(), 'Did not succeed: ' + result?.getErrors());
Id leadId = result?.getLeadId();
Lead lead = leads?.get(leadId);
Assert.areNotEqual(null, lead, 'No lead w/matching Id: ' + leadId);
Assert.areNotEqual(null, result?.getAccountId(), 'Missing ConvertedAccountId');
Assert.areNotEqual(null, result?.getContactId(), 'Missing ConvertedContactId');
Assert.areNotEqual(null, result?.getOpportunityId(), 'Missing ConvertedOpportunityId');
Lead lead = (Lead) MockDml.CONVERTED.get(leadId);
Assert.areNotEqual(null, lead, 'Missing lead: ' + leadId);
Assert.areNotEqual(null, lead?.ConvertedAccountId, 'Lead: Missing ConvertedAccountId');
Assert.areNotEqual(null, lead?.ConvertedContactId, 'Lead: Missing ConvertedContactId');
Assert.areNotEqual(null, lead?.ConvertedOpportunityId, 'Lead: Missing ConvertedOpportunityId');
Assert.areEqual(true, lead?.IsConverted, 'Lead: Wrong IsConverted value');
Assert.areEqual(convertedStatus, lead?.Status, 'Lead: Wrong Status value');
Assert.areEqual(lead?.ConvertedAccountId, result?.getAccountId(), 'Result: Wrong AccountId');
Assert.areEqual(lead?.ConvertedContactId, result?.getContactId(), 'Result: Wrong ContactId');
Assert.areEqual(lead?.ConvertedOpportunityId, result?.getOpportunityId(), 'Result: Wrong OpportunityId');
}
}

Expand Down