Add WlanApi module #1697
Add WlanApi module #1697
Conversation
| } | ||
|
|
||
| int WlanOpenHandle(int dwClientVersion, Pointer pReserved, IntByReference pdwNegotiatedVersion, | ||
| PointerByReference phClientHandle); |
There was a problem hiding this comment.
| PointerByReference phClientHandle); | |
| HANDLEByReference phClientHandle); |
| @Override | ||
| protected List<String> getFieldOrder() { | ||
| return Arrays.asList("dwNumberOfItems", "dwIndex", "InterfaceInfo"); | ||
| } |
There was a problem hiding this comment.
Please use @FieldOrder annotation. See https://github.com/eranl/jna/blob/4073685fec63fb1418ed42d5c0cf4037251f96aa/contrib/platform/src/com/sun/jna/platform/win32/WinCrypt.java#L51-L104 for an example. Applies to all structures.
| @@ -0,0 +1,188 @@ | |||
| package com.sun.jna.platform.win32; | |||
There was a problem hiding this comment.
The license header is missing (see for example
jna/contrib/platform/src/com/sun/jna/platform/win32/Crypt32.java
Lines 1 to 23 in dc44b98
| class WLAN_INTERFACE_INFO extends Structure { | ||
| public GUID InterfaceGuid; | ||
| public char[] strInterfaceDescription = new char[WLAN_MAX_NAME_LENGTH]; | ||
| public int isState; // WLAN_INTERFACE_STATE |
There was a problem hiding this comment.
Please make this javadoc, then people might see this in IDE help. I.e.:
/**
* See {@link WLAN_INTERFACE_STATE} for possible values
*/
public int isState;This applies to other similar constructs in here.
| return Arrays.asList("dwNumberOfItems", "dwIndex", "InterfaceInfo"); | ||
| } | ||
|
|
||
| public void read() { |
| public int wlanConnectionMode; // WLAN_CONNECTION_MODE | ||
| public char[] strProfileName = new char[WLAN_MAX_NAME_LENGTH]; | ||
| public WLAN_ASSOCIATION_ATTRIBUTES wlanAssociationAttributes; | ||
| // Other fields omitted |
There was a problem hiding this comment.
This will break hard, if there is ever a use in an array or embedded inside another structure.
There was a problem hiding this comment.
Is it acceptable to just add a warning about this in the doc, or should I complete these structures?
There was a problem hiding this comment.
If necessary I can live with a warning, on the other hand here is a single field missing which is admittedly a structure itself, but that is also not that big.
| class HANDLE extends WinNT.HANDLE { | ||
| public HANDLE() { | ||
| } | ||
|
|
||
| public HANDLE(Pointer p) { | ||
| super(p); | ||
| } | ||
| } | ||
|
|
||
| class GUID extends Guid.GUID {} |
There was a problem hiding this comment.
These redefinitions are not necessary and should not be here.
2 participants
This is a partial mapping of
WlanApi.h.