Skip to content

Improve error handling in OpenProcess method : Windows32Exception - The parameter is incorrect #1700 #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marktech0813 wants to merge 6 commits into
base: master
Choose a base branch
from
+20 −16
Open

Improve error handling in OpenProcess method : Windows32Exception - The parameter is incorrect #1700 #1701

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ff34ff
Improve error handling in OpenProcess method : Windows32Exception - T…
marktech0813 Nov 11, 2025
5613135
Update CHANGES.md with bug fix details
marktech0813 Nov 11, 2025
2c6396d
Refactor error handling in OpenProcess method
marktech0813 Nov 11, 2025
05634ae
Update WindowUtils.java
marktech0813 Nov 12, 2025
12bdc9f
Update contrib/platform/src/com/sun/jna/platform/WindowUtils.java
marktech0813 Nov 13, 2025
acc1ba9
Update CHANGES.md
marktech0813 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Features

Bug Fixes
---------
* [#1700](https://github.com/java-native-access/jna/issues/1700): Windows: treat `ERROR_INVALID_PARAMETER` from `OpenProcess` in `c.s.j.p.WindowUtils#getProcessFilePath` like `ERROR_ACCESS_DENIED` to avoid spurious `Win32Exception` when enumerating windows whose processes have exited or are otherwise inaccessible.


Release 5.18.1
Expand Down Expand Up @@ -1465,4 +1466,4 @@ Bug Fixes
* Ensure native libraries are only loaded once until released
* Properly handle NULL when the return value is a Structure
* Proper conversion to wchar_t on linux
* Copy full length of Java strings to C strings instead of stopping when a NUL character is encountered
* Copy full length of Java strings to C strings instead of stopping when a NUL character is encountered
33 changes: 18 additions & 15 deletions contrib/platform/src/com/sun/jna/platform/WindowUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,22 +1298,25 @@ public String getProcessFilePath(final HWND hwnd) {
pid.getValue());

if (process == null) {
if(Kernel32.INSTANCE.GetLastError() != WinNT.ERROR_ACCESS_DENIED) {
throw new Win32Exception(Kernel32.INSTANCE.GetLastError());
} else {
process = Kernel32.INSTANCE.OpenProcess(
WinNT.PROCESS_QUERY_LIMITED_INFORMATION,
false,
pid.getValue());

if (process == null) {
if (Kernel32.INSTANCE.GetLastError() != WinNT.ERROR_ACCESS_DENIED) {
throw new Win32Exception(Kernel32.INSTANCE.GetLastError());
} else {
// Ignore windows, that can't be accessed
return "";
switch (Kernel32.INSTANCE.GetLastError()) {
case WinNT.ERROR_ACCESS_DENIED:
case WinError.ERROR_INVALID_PARAMETER:
process = Kernel32.INSTANCE.OpenProcess(
WinNT.PROCESS_QUERY_LIMITED_INFORMATION,
false,
pid.getValue());
if (process == null) {
switch (Kernel32.INSTANCE.GetLastError()) {
case WinNT.ERROR_ACCESS_DENIED:
case WinError.ERROR_INVALID_PARAMETER:
return "";
default:
throw new Win32Exception(Kernel32.INSTANCE.GetLastError());
}
}
}
break;
default:
throw new Win32Exception(Kernel32.INSTANCE.GetLastError());
}
}

Expand Down