fix(usenet): prevent memory leak by closing all segments in Clear() #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
segmentRange.Clear()that caused unbounded memory growthProblem
When downloads stalled or failed,
Clear()would exit on the first segment close error, leaving other segments open. Each unclosed segment holds buffers, causing memory to grow unbounded (observed 4+ GB growth in production).Solution
Clear()to iterate through all segments regardless of individual close errorserrors.Join()Testing
Impact
Critical fix - Without this, the container would eventually OOM during active streaming of large files.
🤖 Generated with Claude Code