fix for upstream triton #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #334 |
superbobry
added a commit
to superbobry/jax-triton
that referenced
this pull request
Mar 14, 2025
This is a backport of the fix proposed by mattjj@ in jax-ml#333. I also fixed a few linter warnings to make sure at least our lint CI is green. Note that the tests will still be red once this PR lands, because Triton does not have a release incorporating all the recent API changes. I manually verified that the tests pass with Triton compiled from their main branch.
superbobry
added a commit
to superbobry/jax-triton
that referenced
this pull request
Mar 14, 2025
This is a backport of the fix proposed by mattjj@ in jax-ml#333. I also fixed a few linter warnings to make sure at least our lint CI is green. Note that the tests will still be red once this PR lands, because Triton does not have a release incorporating all the recent API changes. I manually verified that the tests pass with Triton compiled from their main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think due to these Triton upstream changes:
triton-lang/triton#6099
triton-lang/triton#6109
users are seeing this error message:
AttributeError: module 'triton.runtime.jit' has no attribute 'specialize_impl'
e.g. #330
This PR might make the jax-triton code more robust to triton code changes. I haven't tested it yet...
But more broadly we should identify versions of Triton that jax-triton works with, have those in CI, and explain those in our install instructions. (At the moment, we only ensure jax-triton works with the version of Triton that XLA uses, i.e. this commit.)